Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only remove bookmark tag when it's pinned #7286

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Only remove bookmark tag when it's pinned #7286

merged 1 commit into from
Feb 21, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 16, 2017 •
edited
Loading

Test Plan:

Covered by automatic test

filterOutNonRecents will do the cleanup

fix #7283

Auditors: @bbondy

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@darkdh darkdh added this to the 0.13.5 milestone Feb 16, 2017
@darkdh darkdh self-assigned this Feb 16, 2017
@darkdh darkdh requested a review from bbondy February 16, 2017 14:07
@darkdh
Only remove bookmark tag when it's pinned
576b66a 
filterOutNonRecents will do the cleanup

fix brave#7283

Auditors: @bbondy

Test Plan:
Covered by automatic test
@bbondy bbondy merged commit 3157b8f into brave:master Feb 21, 2017
@srirambv srirambv mentioned this pull request Feb 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@darkdh darkdh

Labels
bug
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.

Deleting bookmark removes pinned item
3 participants
@darkdh @bbondy @luixxiul