Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added tab press to select autocomplete #7134

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Added tab press to select autocomplete #7134

merged 1 commit into from
Feb 15, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 8, 2017 •
edited by bsclifton
Loading

Test Plan

  • Ensure you have auto complete suggestion for on an input filed
  • Press down on the input field to highlight the suggestion
  • Once highlighted press tab, field should be filled

Details

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7132

Auditors

@srirambv @bsclifton

@NejcZdovc
Added tab press to select autocomplete
ed34cd7 
Resovles brave#7132

Auditors: @srirambv @bsclifton

Test Plan:
- Ensure you have auto complete suggestion for on an input filed
- Press down on the input field to highlight the suggestion
- Once highlighted press tab, field should be filled
@NejcZdovc NejcZdovc added this to the 0.13.3 milestone Feb 8, 2017
@NejcZdovc NejcZdovc self-assigned this Feb 8, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.13.4, 0.13.3 Feb 8, 2017
bsclifton
bsclifton approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, everything works great 😄 Very nice touch

Next time one of us is in contextMenu, maybe we can use Enzyme to add unit tests 😄 You can simulate events like keyDown and we can verify the expected behavior

@bsclifton bsclifton merged commit 3316565 into brave:master Feb 15, 2017
@alexwykoff alexwykoff mentioned this pull request Feb 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/autocomplete QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @bsclifton