This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
include current year in PDF statement copyright footer #6880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
reviewed
Jan 27, 2017
| @@ -328,9 +328,13 @@ class ContributionStatement extends ImmutableComponent { | |||
| } | |||
|
|
|||
| get ContributionStatementPageFooter () { | |||
| const l10nDataArgs = { | |||
| currentYear: new Date().getFullYear().toString(10) | |||
There was a problem hiding this comment.
toString's radix is option so doesn't need to be specified and you can even just not convert to a string since it'll be coerced but I'm fine with this. Merging, thanks!
|
++ |
|
@alexwykoff - can you do me a favor? generate a PDF on your system and see if you get the funny characters that i see above (look for the "blurry" image). if not, no worries. @bbondy - i'd prefer to do an integer, but the problem is that it rendered as |
This was referenced Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditor: @bsclifton
Fixes #6878
Test Plan:
brian - on my system, the PDF has "funny" characters around the date. do you see those as well?
