This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Updated sanitization logic for separators #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't allow menu to start with one - don't allow menu to end with one - don't allow only a separator Fixes #5765 Auditors: @bbondy Test Plan: 1. Launch Brave on Windows and go to preferences 2. Disable pocket and any password managers 3. Visit about:about 4. Right click the page; you should not see any separators at the end
|
++ |
This was referenced Dec 30, 2016
This was referenced Jan 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Updated sanitization logic for separators
Fixes #5765
Auditors: @bbondy, @cezaraugusto
Test Plan: