This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Made the width of "Advanced Settings..." button on about:preferences#payments wider #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…payments wider Set min-width:235px to the button to make it as wide as the table data inside '.walletBar' Closes #6285 Auditors: @bradleyrichter @bsclifton Test Plan: 1. Change your lang setting on the browser 2. Open about:preferences#payments 3. Check the width of the button
luixxiul
added
feature/rewards
l10n
polish
|
+++
… On Dec 17, 2016, at 10:31 AM, Suguru Hirahara ***@***.***> wrote:
Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Set min-width:235px to the button to make it as wide as the table data inside '.walletBar'
Closes #6285
Auditors: @bradleyrichter @bsclifton
Test Plan:
Change your lang setting on the browser
Open about:preferences#payments
Check the width of the button
You can view, comment on, or merge this pull request online at:
#6287
Commit Summary
Made the width of "Advanced Settings..." button on about:preferences#payments wider
File Changes
M less/about/preferences.less (4)
Patch Links:
https://github.com/brave/browser-laptop/pull/6287.patch
https://github.com/brave/browser-laptop/pull/6287.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@bradleyrichter thanks! merged :-) |
|
++ 😄 |
This was referenced Dec 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Set min-width:235px to the button to make it as wide as the table data inside '.walletBar'
Closes #6285
Auditors: @bradleyrichter @bsclifton
Test Plan: