Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Made all place of Cubits/buybitcoinworldwide.com button clickable #6051

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Made all place of Cubits/buybitcoinworldwide.com button clickable #6051

merged 1 commit into from
Dec 7, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 6, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bsclifton @bbondy

Fixes #6050

Test Plan:

  1. Disable "worldWidePanel"
  2. Open about:preferences#payments
  3. Click the top left corner of "Cubits" button
  4. Enable "worldWidePanel"
  5. Open about:preferences#payments
  6. Click the top left corner of "buybitcoinworldwide.com" button

@jkup
Copy link
Contributor

jkup commented Dec 6, 2016

This could probably just be an anchor, right?

@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 7, 2016

Because having button element here maintains the consistency (the other buttons on the modal have been replaced from span to button) I think we should keep it.

@luixxiul luixxiul added this to the 0.13.0 milestone Dec 7, 2016
@bsclifton
Copy link
Member

bsclifton commented Dec 7, 2016

After reviewing, I believe the same change needs to be made here:
https://github.com/brave/browser-laptop/pull/6051/files#diff-e3eeb751016b2ce9f8278efce585a461R373

I ran into the same issue when I was shown the buybitcoinworldwide.com button (I was unable to click the edges).

Since I'm in the US (which would usually show Coinbase), I tested by reversing these two values:
https://github.com/brave/browser-laptop/pull/6051/files#diff-e3eeb751016b2ce9f8278efce585a461R489

Auditors: @bsclifton

Fixes #6050

Test Plan:
1. Disable "worldWidePanel"
2. Open about:preferences#payments
3. Click the top left corner of "Cubits" button
4. Enable "worldWidePanel"
5. Open about:preferences#payments
6. Click the top left corner of "buybitcoinworldwide.com" button
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 7, 2016

Updated, thanks @bsclifton :-)

@luixxiul luixxiul changed the title Made all place of Cubits button clickable Made all place of Cubits/buybitcoinworldwide.com button clickable Dec 7, 2016
@bsclifton
Copy link
Member

Works great, thanks! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants