Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove Open in new tab from context menu while in a private browsing tab #5671

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

Ihyatt
Copy link
Contributor

@Ihyatt Ihyatt commented Nov 16, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5610

Test Plan:
Open a private tab and browse somewhere.
Right click on a link, only "New Private Tab" and "New Window" should display.

@ayumi ayumi self-assigned this Nov 16, 2016
@ayumi
Copy link
Contributor

ayumi commented Nov 16, 2016

tried it out, works – thanks!

@ayumi ayumi merged commit 78a2fb6 into brave:master Nov 16, 2016
@bbondy bbondy added this to the 0.12.10 release milestone Nov 17, 2016
@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

Thanks or the contribution @Ihyatt! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants