Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add F6 shortcut for focusing the URL bar #5670

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Add F6 shortcut for focusing the URL bar #5670

merged 1 commit into from
Nov 16, 2016

Conversation

kellyk
Copy link

@kellyk kellyk commented Nov 16, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fix #4464
Test plan:
Open browser
Hit F6
URL bar should get focus

Add F6 shortcut for focusing the URL bar
94fd35f 
Fix brave#4464
Test plan:
Open browser
Hit F6
URL bar should get focus
@ayumi
Copy link
Contributor

ayumi commented Nov 16, 2016

Tried it out, lgtm ⭐

@ayumi ayumi merged commit 19c8aa4 into brave:master Nov 16, 2016
@bsclifton
Copy link
Member

Awesome, thanks! 😄

@bbondy bbondy added this to the 0.12.10 release milestone Nov 17, 2016
@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

Thanks @kellyk!

This was referenced Nov 21, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/keyboard-shortcuts QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.10 release
Development

Successfully merging this pull request may close these issues.
7 participants
@kellyk @ayumi @bsclifton @bbondy @alexwykoff @luixxiul @srirambv