Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix syncing between react and DOM urlbar focus/select #5573

Closed
wants to merge 1 commit into from

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Nov 12, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

previously it seems that the urlbar was getting selected
every time the react select state was updated; yet then the
react selected state would be updated to false.

this may fix #5529

Auditors: @bbondy

Test Plan:
follow Alex's test steps in #5529
and check that the first character is not deleted.

previously it seems that the urlbar was getting selected
every time the react select state was updated; yet then the
react selected state would be updated to false.

this may fix #5529

Auditors: @bbondy

Test Plan:
follow Alex's test steps in #5529
and check that the first character is not deleted.
@bbondy
Copy link
Member

bbondy commented Nov 12, 2016

I think this is maybe the same thing that this fixed:
fcde124
Thoughts?

@bbondy
Copy link
Member

bbondy commented Nov 12, 2016

I'll close becauseI think that's the case that it's fixed by that one, but please re-open if you don't think so, or if you think this should be merged too (it is bitrot though by mine)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression : autocomplete is deleting the first character typed in the url bar
5 participants