Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL is normalized when updating favicon for a given site #5445

Merged
merged 1 commit into from
Nov 7, 2016
Merged

URL is normalized when updating favicon for a given site #5445

merged 1 commit into from
Nov 7, 2016

Commits on Nov 7, 2016

  1. URL is normalized when updating favicon for a given site

    Fixes #4860
    
    Auditors: @cezaraugusto
    
    Test Plan:
    1. if testing from source, make sure to run `npm install` to get new dependency
    2. Launch Brave and go to about:bookmarks
    3. Use the star+ icon to add a new bookmark and type "https://clifton.io" (no slash)
    4. Enable the bookmarks toolbar, if that makes it easier to see the bookmark icons.
    5. Notice there is no favicon yet
    6. Visit https://clifton.io/#testing123
    7. Notice the favicon is updated
    bsclifton committed Nov 7, 2016
    Configuration menu
    Copy the full SHA
    0cfda2f View commit details
    Browse the repository at this point in the history