Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Long bookmark folder names should be truncated #4752

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 13, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4739

Auditors: @bradleyrichter @alexwykoff

Test Plan:

We can't just add max-width: 50% because then it'll only take up half the screen when the columns float underneath each other but wrapping it in a breakpoint works.

Add a bookmark folder with a really long name and make sure it looks good with both a huge and small screen.
screen shot 2016-10-13 at 2 44 34 pm
screen shot 2016-10-13 at 2 44 44 pm

@jkup jkup added design A design change, especially one which needs input from the design team. feature/bookmarks labels Oct 13, 2016
@jkup jkup added this to the 0.12.6dev milestone Oct 13, 2016
@alexwykoff
Copy link
Contributor

alexwykoff commented Oct 14, 2016

lgtm, noticed a performance issue of tracking objects while resizing:
bookmark_squeeze

i'll open a separate issue for that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants