This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix autofill regression caused by refactor #4669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
commented
Oct 11, 2016
| @@ -20,7 +20,6 @@ const {tabFromFrame} = require('../state/frameStateUtil') | |||
| const {l10nErrorText} = require('../../app/common/lib/httpUtil') | |||
| const {aboutUrls, getSourceAboutUrl, isIntermediateAboutPage, navigatableTypes} = require('../lib/appUrlUtil') | |||
| const Serializer = require('../dispatcher/serializer') | |||
| const { showBookmarkFolderInit } = require('../contextMenus') | |||
There was a problem hiding this comment.
this is the line which broke things (definitely my bad)
bsclifton
changed the title
bsclifton
commented
Oct 11, 2016
| @@ -841,7 +813,7 @@ const doAction = (action) => { | |||
| if (getSetting(settings.AUTO_HIDE_MENU)) { | |||
| doAction({actionType: WindowConstants.WINDOW_TOGGLE_MENUBAR_VISIBLE, isVisible: false}) | |||
| } else { | |||
| hideContextMenu(action) | |||
| doAction({actionType: WindowConstants.WINDOW_SET_CONTEXT_MENU_DETAIL}) | |||
| } | |||
| doAction({actionType: WindowConstants.WINDOW_SET_SUBMENU_SELECTED_INDEX}) | |||
| doAction({actionType: WindowConstants.WINDOW_SET_BOOKMARKS_TOOLBAR_SELECTED_FOLDER_ID}) | |||
There was a problem hiding this comment.
Glad this came up- this is something I missed while doing the refactor. Resetting the menu status is supposed to clear the selected folder ID. This action never got renamed to the new one
|
This PR no longer needed- it was included as one of the commits in #4658 (I was still working on that one and was going to drop it via rebase) |
|
agree on the contextMenus -> windowStore dependency. Any state it requires should be passed in like any other component |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the refactoring done in #4361 unfortunately broke autofill. This commit reverts the parts that broke it back to the pre-refactor state and keeps the parts that were OK.
Properly fixes #1725
js/store/windowStore.jsandjs/contextMenus.jshad a circular dependency with each other. Ultimately,contextMenus.jsshouldn't have a dependency on windowStore (IMO). I tried to keep the refactored code in place and while eliminating the windowStore dependency incontextMenus.jsand realized this is not an easy task (we'll have to revisit in future)Auditors: @darkdh @bridiver
Test Plan: follow steps from original PR. The original automated tests work great