This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Show bookmarks toolbar automatically if it was disabled after importing bookmarks successfully #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng bookmarks successfully fix brave#4507 Auditors: @bbondy Test Plan: 1. Make sure bookmakrs toolbar doesn't show 2. Import bookmarks from browser 3. bookmarks toolbar will show after successful import 1. Make sure bookmakrs toolbar doesn't show 2. Import bookmarks from html 3. bookmarks toolbar will show after successful import 1. Make sure bookmakrs toolbar doesn't show 2. Make sure there already exist some bookmarks 3. Import bookmarks from browser 4. bookmarks toolbar should not show after successful import 1. Make sure bookmakrs toolbar doesn't show 2. Make sure there already exist some bookmarks 3. Import bookmarks from html 4. bookmarks toolbar should not show after successful import
|
++ |
This was referenced Oct 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #4507
Auditors: @bbondy
Test Plan: