This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
0.12.2dev titlebar fixes (round 2) #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
bsclifton
changed the title
|
after testing some more, it's got at least one issue: Working on fix... |
bsclifton
changed the title
|
fixed- menu was hardcoded to 29px. even slimmer now 😄 |
|
and fixed the issue w/ caption buttons. Had a bad selector |
- Container cleanup in main.js after properly learning how to use display:flex - dead areas are now isolated to their own div and ONLY those have `drag` applied (versus the parent container) - Fix wrapping of new tab button (only showed when magnified 150%) - Cleanup windowCaptionButton to use classSets Fixes #4245 Fixes #4236 Fixes (as best I possibly can) #4235
|
Using this pic as reference: There are still some un-draggable areas:
these are going to be hard to get 😦 The rest are fixed 👍 |
|
++ |
This was referenced Sep 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dragapplied (versus the parent container having drag and excluded children havingno-drag)Fixes #4245
Fixes #4236
Appears to mostly fix #4235
Auditors: @bbondy