Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Block script icon is off location when URL bar is hidden #4014

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 14, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4007

Test Plan:

Experiment with both bookmarking and blocking scripts on websites and make sure both icons look correct on the top of the browser.

Auditors @diracdeltas @bradleyrichter

Also, @bradleyrichter I noticed some code in there that looks like maybe those icons used to be somewhat see through and then bolden on hover? Is that still desired?

@jkup jkup added this to the 0.12.1dev milestone Sep 14, 2016
@jkup jkup added the design A design change, especially one which needs input from the design team. label Sep 14, 2016
@diracdeltas
Copy link
Member

@jkup yup the icons should darken on hover so that it's obvious they are clickable.

@diracdeltas
Copy link
Member

lgtm but please re-add the hover darkening

@jkup
Copy link
Contributor Author

jkup commented Sep 15, 2016

@diracdeltas thanks! updated.

@diracdeltas
Copy link
Member

++ thanks

@diracdeltas diracdeltas merged commit 87dfc12 into master Sep 15, 2016
@diracdeltas diracdeltas deleted the script-icon branch September 15, 2016 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants