Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes #2444: Pressing down on URL bar should open autosuggest #2572

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Fixes #2444: Pressing down on URL bar should open autosuggest #2572

merged 2 commits into from
Jul 22, 2016

Conversation

willy-b
Copy link
Contributor

@willy-b willy-b commented Jul 19, 2016

@willy-b
Copy link
Contributor Author

willy-b commented Jul 19, 2016

Oops, it looks like some checks have failed.
However, the AppVeyor errors seem to be in an early part of the build process (npm preinstall/install ; installing bloom-filter-cpp?) which was not modified. I didn't change any dependencies, so confused how the 'npm install' step got broken.

See below:
appveyor_builderror_1
appveyor_builderror_2

@bbondy
Copy link
Member

bbondy commented Jul 19, 2016

We don't have AppVeyor fully setup yet so you can ignore that. Also Travis will intermittently fail so no worries there.

@willy-b
Copy link
Contributor Author

willy-b commented Jul 19, 2016

OK, consistent with that, the Travis test failures are all timeouts:
travisintegrationtests

I'll still look into those tests locally and see if these timeouts might be reflecting a UI slowdown from the changes.

@bbondy
Copy link
Member

bbondy commented Jul 19, 2016

This is a little different behaviour than what I was expecting and what chrome/firefox does.
Could you only show when there is an onKeyDown event?

@willy-b
Copy link
Contributor Author

willy-b commented Jul 20, 2016

Whoops, thought the issue was asking for dropdown on mouse-down! Fixed now :-).

@bbondy
Copy link
Member

bbondy commented Jul 22, 2016

perfect, thanks for the patch!

@bbondy bbondy merged commit 20cb839 into brave:master Jul 22, 2016
@luixxiul luixxiul added this to the 0.11.2dev milestone Jul 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants