Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes site settings for delete sites #14260

Merged
merged 1 commit into from
May 29, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 28, 2018

Resolves #14245

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

defined in #14245

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@jasonrsadler
Copy link
Contributor

jasonrsadler commented May 29, 2018

If auto-include is left on and site is removed from ledger completely, revisiting it relists, but does not include it. Is this right?

Also, is this issue possible dupe?
#13283 (comment)

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler I can't reproduce this. What are the steps exactly?

@jasonrsadler
Copy link
Contributor

Now I can't either. Disregard.

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not repro issue mentioned above, code looks good, test plan works well

@NejcZdovc NejcZdovc merged commit 21f24d0 into brave:master May 29, 2018
NejcZdovc added a commit that referenced this pull request May 29, 2018
Removes site settings for delete sites
NejcZdovc added a commit that referenced this pull request May 29, 2018
Removes site settings for delete sites
@NejcZdovc
Copy link
Contributor Author

master 21f24d0
0.23 116e53f
0.22 84183b0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants