Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds batch voting #14191

Merged
merged 1 commit into from
May 24, 2018
Merged

Adds batch voting #14191

merged 1 commit into from
May 24, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 21, 2018 •
edited
Loading

Resolves #14190

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • enable payments
  • add some publishers
  • make contribution
  • make sure that contribution is done and that PDF is generated

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc self-assigned this May 21, 2018
@NejcZdovc NejcZdovc added this to the 0.22.x Release 5 milestone May 22, 2018
@jasonrsadler
Copy link
Contributor

blocked: brave-intl/bat-client#74

@NejcZdovc NejcZdovc force-pushed the feature/#14190-batch branch from 39d5b82 to b9fafc3 Compare May 24, 2018 06:05
@NejcZdovc NejcZdovc requested a review from ryanml May 24, 2018 06:11
@ryanml ryanml closed this May 24, 2018
@ryanml ryanml reopened this May 24, 2018
@NejcZdovc
Adds batch voting
f0dffef 
Resolves brave#14190

Auditors:

Test Plan:
@NejcZdovc NejcZdovc force-pushed the feature/#14190-batch branch from b9fafc3 to f0dffef Compare May 24, 2018 06:15
ryanml
ryanml approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan works well ++

@NejcZdovc NejcZdovc merged commit 4d3cd36 into brave:master May 24, 2018
NejcZdovc added a commit that referenced this pull request May 24, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
6fbcba7 
Adds batch voting
NejcZdovc added a commit that referenced this pull request May 24, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
204b90b 
Adds batch voting
@NejcZdovc
Copy link
Contributor Author

master 4d3cd36
0.23 6fbcba7
0.22-release5 204b90b

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented May 25, 2018 •
edited
Loading

0.22 2608c7a

NejcZdovc added a commit that referenced this pull request May 25, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
2608c7a 
Adds batch voting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @jasonrsadler @ryanml