Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Call mockery.deregisterAll when done after registering mocks. #14168

Merged
merged 1 commit into from
May 18, 2018

Conversation

riastradh-brave
Copy link
Contributor

Fixes hosed fs module in other tests, not currently exercised but
perhaps soon to be in tor branch.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes hosed fs module in other tests, not currently exercised but
perhaps soon to be in tor branch.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++! 😄

@bsclifton bsclifton merged commit 22e62bf into master May 18, 2018
@bsclifton bsclifton deleted the riastradh-fix-sessionstoretest-mockery branch May 18, 2018 05:24
bsclifton added a commit that referenced this pull request May 18, 2018
…ockery

Call mockery.deregisterAll when done after registering mocks.
bsclifton added a commit that referenced this pull request May 18, 2018
…ockery

Call mockery.deregisterAll when done after registering mocks.
@bsclifton
Copy link
Member

master 22e62bf
0.23.x e257cc0
0.22.x 864145d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants