Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes contribution process #14022

Merged
merged 1 commit into from
May 4, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 4, 2018

Resolves #14018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

run all tests with LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true LEDGER_ENVIRONMENT=staging LEDGER_VERBOSE=true
a) test a

  1. enable payments
  2. add funds
  3. change reconcile stamp to be in past
  4. make sure that contribution date is pushed for a month and there is no contribution progress message

a) test b

  1. enable payments
  2. add funds
  3. visit some sites
  4. change reconcile stamp to be in past
  5. make sure that contribution date is not pushed for a month and there is contribution progress message
  6. make sure that contribution is completed

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone May 4, 2018
@NejcZdovc NejcZdovc self-assigned this May 4, 2018
@codecov-io
Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #14022 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master   #14022      +/-   ##
==========================================
- Coverage   56.47%   56.46%   -0.01%     
==========================================
  Files         284      284              
  Lines       29357    29357              
  Branches     4879     4880       +1     
==========================================
- Hits        16578    16577       -1     
- Misses      12779    12780       +1
Flag Coverage Δ
#unittest 56.46% <87.5%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/renderer/components/preferences/paymentsTab.js 65.56% <ø> (ø) ⬆️
app/common/lib/ledgerUtil.js 96.09% <100%> (ø) ⬆️
...r/components/preferences/payment/enabledContent.js 64.76% <100%> (ø) ⬆️
app/browser/api/ledger.js 63.47% <80%> (+0.34%) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

@NejcZdovc NejcZdovc force-pushed the fix/#14018-contribution branch from 15a4232 to 8efc6c5 Compare May 4, 2018 09:56
Resolves brave#14018

Auditors:

Test Plan:
@NejcZdovc NejcZdovc force-pushed the fix/#14018-contribution branch from 8efc6c5 to d580e2c Compare May 4, 2018 10:09
@jasonrsadler
Copy link
Contributor

jasonrsadler commented May 4, 2018

When testing, the only thing that is not obvious is the 'Next contribution date' is always June 3. For test A, should I be expecting it to push to July 3rd?

Other than that, everything else tests good according to test plan above.

@NejcZdovc
Copy link
Contributor Author

@jasonrsadler no, it should be pushed back for a month from now, so it should be always June

@jasonrsadler
Copy link
Contributor

If it should be June for both tests, then everything checks out good. 👍

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Nice work

Copy link
Collaborator

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ manually tested works fine

@NejcZdovc NejcZdovc merged commit 396c507 into brave:master May 4, 2018
NejcZdovc added a commit that referenced this pull request May 4, 2018
NejcZdovc added a commit that referenced this pull request May 4, 2018
@NejcZdovc
Copy link
Contributor Author

master 396c507
0.23 7a0e848
0.22-release3 31e4680

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants