-
Notifications
You must be signed in to change notification settings - Fork 970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14022 +/- ##
==========================================
- Coverage 56.47% 56.46% -0.01%
==========================================
Files 284 284
Lines 29357 29357
Branches 4879 4880 +1
==========================================
- Hits 16578 16577 -1
- Misses 12779 12780 +1
|
15a4232
to
8efc6c5
Compare
Resolves brave#14018 Auditors: Test Plan:
8efc6c5
to
d580e2c
Compare
When testing, the only thing that is not obvious is the 'Next contribution date' is always June 3. For test A, should I be expecting it to push to July 3rd? Other than that, everything else tests good according to test plan above. |
@jasonrsadler no, it should be pushed back for a month from now, so it should be always June |
If it should be June for both tests, then everything checks out good. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ manually tested works fine
Resolves #14018
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
run all tests with
LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true LEDGER_ENVIRONMENT=staging LEDGER_VERBOSE=true
a) test a
a) test b
Reviewer Checklist:
Tests