This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Fixes wallet recovery dialogue re-appearing on relaunch after a successful recovery. #13850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge when a wallet recovery is successful, and when it is cancelled or closed out of.
Codecov Report
@@ Coverage Diff @@
## master #13850 +/- ##
==========================================
- Coverage 56.62% 56.57% -0.05%
==========================================
Files 283 283
Lines 28849 28855 +6
Branches 4785 4786 +1
==========================================
- Hits 16337 16326 -11
- Misses 12512 12529 +17
|
Sadly we had the same problem with backup overlay. Let's try to find more general solution. I was thinking to add some code to the general hideOverlay function and check if # is present we should remove it from the url. I would also try to remove it via history API instead of reloading the page if possible. |
@NejcZdovc, changes pushed:
|
…t entry Reverting old solution
84e2f89
to
7f194c9
Compare
NejcZdovc
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ works great
NejcZdovc
added a commit
that referenced
this pull request
Apr 19, 2018
Fixes wallet recovery dialogue re-appearing on relaunch after a successful recovery.
NejcZdovc
added a commit
that referenced
this pull request
Apr 19, 2018
Fixes wallet recovery dialogue re-appearing on relaunch after a successful recovery.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13645
Additionally, per the feedback on this PR:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
vower obovoid menace tobogganist hoyle honoree pixel pestilently disconcertment sellable ruffing supervision zoroastrian based coparent slackened
Links:
recovery:
about:preferences#payments?ledgerRecoveryOverlayVisible
backup:
about:preferences#payments?ledgerBackupOverlayVisible
Reviewer Checklist:
Tests
cc: @bsclifton @btlechowski