This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Send hostname option to webtorrent to mitigate DNS rebinding #13844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12616
complicated test plan:
system setup
/etc/hosts
or your system equivalent, add this entry so that brave.site is mapped to localhost:127.0.0.1 brave.site
python -m SimpleHTTPServer 8000
or equivalentorigin: window.location.origin
toorigin: '*'
(this helps simulate a DNS rebinding attack)testing the PR
https://webtorrent.io/torrents/sintel.torrent
and click the 'start torrent' buttonSubmitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests