Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Opens add funds overlay when clicking on it in the notification #13776

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 9, 2018

Resolves #4310

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • clean profile
  • enable payments
  • change timestamp to be less then a day of now (now - timestamp < day)
  • wait for add funds notification to be shown
  • click on Add funds which should open add funds overlay

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc self-assigned this Apr 9, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton April 9, 2018 08:55
@codecov-io
Copy link

codecov-io commented Apr 9, 2018

Codecov Report

Merging #13776 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13776      +/-   ##
==========================================
- Coverage   56.77%   56.74%   -0.04%     
==========================================
  Files         285      285              
  Lines       29042    29042              
  Branches     4800     4800              
==========================================
- Hits        16489    16480       -9     
- Misses      12553    12562       +9
Flag Coverage Δ
#unittest 56.74% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledgerNotifications.js 69.87% <ø> (ø) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

@jasonrsadler jasonrsadler changed the title Opens add founds overlay when clicking on it in the notification Opens add funds overlay when clicking on it in the notification Apr 10, 2018
@jasonrsadler jasonrsadler self-requested a review April 10, 2018 02:18
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works great @NejcZdovc
++

@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x Release 3 (Beta channel) Apr 17, 2018
@NejcZdovc NejcZdovc merged commit 8014a0e into brave:master Apr 18, 2018
NejcZdovc added a commit that referenced this pull request Apr 18, 2018
Opens add funds overlay when clicking on it in the notification
NejcZdovc added a commit that referenced this pull request Apr 18, 2018
Opens add funds overlay when clicking on it in the notification
@NejcZdovc
Copy link
Contributor Author

master 8014a0e
0.23 7e55642
0.22 2290386

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants