Fixes null case for fields

[NejcZdovc]

Resolves #13751

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

• start browser with LEDGER_VERBOSE=true flag
• make sure that there is no null error

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[ryanml]

@NejcZdovc This works well, but overall we are just doing a falsy check for field (seems to be able to be either false or undefined)

In this case inside a forEach, I feel it's a little cleaner to stick the fail case at the top of the callback like:

if (!field) return

[NejcZdovc]

@ryanml I agree, your approach is cleaner. Code changed

[codecov-io]

Codecov Report

Merging #13753 into master will decrease coverage by 0.03%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master   #13753      +/-   ##
==========================================
- Coverage   56.63%   56.59%   -0.04%     
==========================================
  Files         283      283              
  Lines       28848    28849       +1     
  Branches     4784     4785       +1     
==========================================
- Hits        16338    16328      -10     
- Misses      12510    12521      +11

Flag	Coverage Δ
#unittest	56.59% <40%> (-0.04%)	⬇️

Impacted Files	Coverage Δ
app/browser/api/ledger.js	62.76% <40%> (-0.08%)	⬇️
js/stores/appStoreRenderer.js	91.66% <0%> (-8.34%)	⬇️
app/renderer/components/reduxComponent.js	57.75% <0%> (-3.45%)	⬇️
js/stores/windowStore.js	28.46% <0%> (-0.3%)	⬇️

[ryanml]

lgtm! 👍

[jasonrsadler]

lgtm 🥇

[NejcZdovc]

master a4cdee8
0.23 9826e31
0.22 ef4f0f8