Menu items which need a window will create / show one if needed

[petemill]

Fix #13689
Partially addresses some items in #8164

This bug was caused because menu items were using a hidden window for their new tabs.

We should not use electron{.remote}.BrowserWindow.getAllWindows() or .get{Active, Focused}Window directly. There are two reasons that could have bad results:

1. We create BrowserWindows which are not normal tabbed renderer windows (e.g. some code that runs on Bookmark creation)
2. We have a hidden window sometimes (the Buffer Window)
   Instead call app/browser/window.js: getAllRendererWindows and getActiveWindowId.
   Fix for main menu actions, which can be called when there are no windows, but when searching for BrowserWindow.

Test Plan:

• Check all menu items open new tab in currently active window
• Check all menu items open new tab in currently active window, when app is not focused
• Check all menu items open new tab in new window if there is no visible window
• Check tabs in all windows are persisted on restart when app / windows close
• Check process quits in Windows when last visible window is closed

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

• Adequate test coverage exists to prevent regressions

• Tests should be independent and work correctly when run individually or as a suite ref

• New files have MPL2 license header

[codecov-io]

Codecov Report

Merging #13749 into master will decrease coverage by <.01%.
The diff coverage is 13.63%.

@@            Coverage Diff             @@
##           master   #13749      +/-   ##
==========================================
- Coverage   56.78%   56.77%   -0.01%     
==========================================
  Files         285      285              
  Lines       29038    29042       +4     
  Branches     4803     4800       -3     
==========================================
+ Hits        16488    16489       +1     
- Misses      12550    12553       +3

Flag	Coverage Δ
#unittest	56.77% <13.63%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
app/common/commonMenu.js	54% <ø> (+1.79%)	⬆️
app/browser/reducers/tabsReducer.js	39.94% <20%> (-0.11%)	⬇️
app/browser/windows.js	33.44% <8.33%> (-0.23%)	⬇️

[bsclifton]

@petemill looks like a lot of the items called out in #8164 don't work:
(screenshot of checklist from that issue after I ran through it)

When doing many of those, I'm getting this error via stdout:

An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property 'id' of null
    at /Users/clifton/Documents/browser-laptop/app/common/lib/menuUtil.js:171:60
    at MenuItem.click (/Users/clifton/Documents/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/menu-item.js:59:9)
    at Function.executeCommand (/Users/clifton/Documents/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/menu.js:121:15)

[bsclifton]

Works great! 😄 👍

[bsclifton]

master 56f9e72
0.23.x 0f240f7
0.22.x cb60d71

[petemill]

0.22.x-c66 a415cb0