Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes ledgerPinPercentage setting #13743

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 5, 2018

Resolves #13035

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • general ledger regression, focused on pinned functionality

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#13035

Auditors:

Test Plan:
@codecov-io
Copy link

codecov-io commented Apr 5, 2018

Codecov Report

Merging #13743 into master will decrease coverage by 0.06%.
The diff coverage is 51.28%.

@@            Coverage Diff             @@
##           master   #13743      +/-   ##
==========================================
- Coverage   56.65%   56.59%   -0.07%     
==========================================
  Files         285      285              
  Lines       28920    28906      -14     
  Branches     4782     4781       -1     
==========================================
- Hits        16385    16358      -27     
- Misses      12535    12548      +13
Flag Coverage Δ
#unittest 56.59% <51.28%> (-0.07%) ⬇️
Impacted Files Coverage Δ
app/browser/api/ledger.js 61.6% <ø> (-0.01%) ⬇️
app/common/state/ledgerState.js 84.47% <ø> (-0.48%) ⬇️
js/state/syncUtil.js 39.35% <ø> (ø) ⬆️
js/constants/appConstants.js 100% <ø> (ø) ⬆️
app/browser/reducers/ledgerReducer.js 43.45% <0%> (-0.44%) ⬇️
js/actions/appActions.js 18.49% <0%> (-0.1%) ⬇️
...erer/components/preferences/payment/pinnedInput.js 51.35% <85.71%> (ø) ⬆️
...erer/components/preferences/payment/ledgerTable.js 86.25% <87.5%> (+0.13%) ⬆️
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
... and 2 more

@jasonrsadler jasonrsadler self-requested a review April 13, 2018 13:10
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x Release 3 (Beta channel) Apr 17, 2018
@NejcZdovc NejcZdovc merged commit fccdc44 into brave:master Apr 18, 2018
NejcZdovc added a commit that referenced this pull request Apr 18, 2018
Removes ledgerPinPercentage setting
NejcZdovc added a commit that referenced this pull request Apr 18, 2018
Removes ledgerPinPercentage setting
@NejcZdovc
Copy link
Contributor Author

master fccdc44
0.23 1073285
0.22 8fe2319

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants