Updates recovery dialog text and buttons

[NejcZdovc]

Resolves #11857

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

• start browser
• enable payments
• go to recovery dialog
• make sure that it's the same as spec

New look

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[codecov-io]

Codecov Report

Merging #13742 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13742      +/-   ##
==========================================
- Coverage   56.53%   56.49%   -0.05%     
==========================================
  Files         283      283              
  Lines       28817    28818       +1     
  Branches     4777     4776       -1     
==========================================
- Hits        16293    16281      -12     
- Misses      12524    12537      +13

Flag	Coverage Δ
#unittest	56.49% <0%> (-0.05%)	⬇️

Impacted Files	Coverage Δ
app/renderer/components/preferences/paymentsTab.js	68.27% <ø> (ø)	⬆️
js/about/preferences.js	61.18% <ø> (-0.07%)	⬇️
...r/components/preferences/payment/ledgerRecovery.js	38% <0%> (+0.74%)	⬆️
js/stores/appStoreRenderer.js	91.66% <0%> (-8.34%)	⬇️
app/renderer/components/reduxComponent.js	57.75% <0%> (-3.45%)	⬇️
js/stores/windowStore.js	28.46% <0%> (-0.3%)	⬇️
app/browser/api/ledger.js	62.43% <0%> (-0.18%)	⬇️

[arsalankhalid]

Oh no, that sucks I did this :( I guess I took too long to get it covered as it was on my plate. I'll give your branch a whirl, although not sure why you removed all this stuff in preferences, with hiding overlays?

if (overlayName === 'addFunds' && isVisible === false) {	
-      // Hide the child overlays when the parent is closed	
-      stateDiff['bitcoinOverlayVisible'] = false	
-      stateDiff['qrcodeOverlayVisible'] = false	
-    }

And also some first, second recovery keys.

[NejcZdovc]

@arsalankhalid this is just some dead old code that was there and I removed it.

[jasonrsadler]

'....will be replace the current...' should be '.....will replace the current....'

[NejcZdovc]

fixed

[jasonrsadler]

Font doesn't look the same from mockup on that sentence either. I'll let @bradleyrichter weigh in.

[bradleyrichter]

The font on the footnote can be Regular and not Bold. Otherwise, it looks good!

[NejcZdovc]

@bradleyrichter remove bold, updated image in the first comment

[bradleyrichter]

thanks all!

[jasonrsadler]

Looks Good!

[NejcZdovc]

master 36d892d
0.23 0d64197
0.22 5564d3a