Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes recover flow when seed is corrupted #13607

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 26, 2018

Resolves #13583

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Launch brave with LEDGER_ENVIRONMENT=staging and LEDGER_VERBOSE=true with a clean profile
  2. Enable payments
  3. Save recovery key
  4. Close Brave
  5. Open ledger-state.json and modify seed (remove some of them)
  6. Launch Brave with same parameters from step 1
  7. Navigate to Payments, overlay is shown.
  8. Click on recover button
  9. Copy/Paste words or import them.
  10. Successful wallet recovery, close popup
  11. Corrupt message is not displayed

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.22.x (Beta Channel) milestone Mar 26, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 26, 2018
@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

Merging #13607 into master will increase coverage by 0.01%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master   #13607      +/-   ##
==========================================
+ Coverage   56.74%   56.75%   +0.01%     
==========================================
  Files         285      285              
  Lines       28797    28810      +13     
  Branches     4755     4757       +2     
==========================================
+ Hits        16341    16352      +11     
- Misses      12456    12458       +2
Flag Coverage Δ
#unittest 56.75% <88.23%> (+0.01%) ⬆️
Impacted Files Coverage Δ
app/common/state/ledgerState.js 84.95% <100%> (+0.22%) ⬆️
app/browser/api/ledger.js 61.59% <81.81%> (+0.03%) ⬆️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great- code changes look good 😄 👍

@bsclifton bsclifton merged commit 03e30fe into brave:master Mar 26, 2018
NejcZdovc pushed a commit that referenced this pull request Mar 28, 2018
Fixes recover flow when seed is corrupted
NejcZdovc pushed a commit that referenced this pull request Mar 28, 2018
Fixes recover flow when seed is corrupted
@NejcZdovc
Copy link
Contributor Author

master 03e30fe
0.23 2f2f58e
0.22 0c503ab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corrupt wallet message does not go away after recovering your wallet
3 participants