Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds broken seed overlay #13551

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Adds broken seed overlay #13551

merged 1 commit into from
Mar 22, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 21, 2018 •
edited
Loading

Resolves #13424

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. clean profile
  2. enable payments
  3. close browser
  4. open ledger-state.json and modify seed (remove some of them)
  5. start browser again
  6. you should see an overlay
  7. clicking on recover should open recover dialog

Expected overlay:
image

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.22.x (Beta Channel) milestone Mar 21, 2018
@NejcZdovc NejcZdovc self-assigned this Mar 21, 2018
@NejcZdovc NejcZdovc force-pushed the feature/#13424-seed branch 3 times, most recently from bc1d9d5 to 171418a Compare March 22, 2018 00:06
@codecov-io
Copy link

codecov-io commented Mar 22, 2018 •
edited
Loading

Codecov Report

Merging #13551 into master will decrease coverage by <.01%.
The diff coverage is 48.35%.

@@            Coverage Diff             @@
##           master   #13551      +/-   ##
==========================================
- Coverage   56.74%   56.74%   -0.01%     
==========================================
  Files         284      285       +1     
  Lines       28729    28782      +53     
  Branches     4744     4752       +8     
==========================================
+ Hits        16302    16331      +29     
- Misses      12427    12451      +24
Flag Coverage Δ
#unittest 56.74% <48.35%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/locale.js 35.77% <ø> (ø) ⬆️
app/browser/tabs.js 23.79% <ø> (+0.1%) ⬆️
app/browser/reducers/ledgerReducer.js 43.89% <100%> (ø) ⬆️
app/common/constants/ledgerStatuses.js 100% <100%> (ø)
...r/components/preferences/payment/enabledContent.js 66.92% <43.58%> (-7.85%) ⬇️
app/browser/api/ledger.js 61.53% <66.66%> (-0.14%) ⬇️
js/stores/windowStore.js 28.75% <0%> (+0.29%) ⬆️
... and 3 more

mrose17
mrose17 previously approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

bsclifton
bsclifton reviewed Mar 22, 2018
View reviewed changes
app/common/constants/ledgerStatuses.js Outdated
* You can obtain one at http://mozilla.org/MPL/2.0/. */

const statuses = {
CORRUPTED: 'corruptedSeed',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be more specific? ex: CORRUPTED_SEED? in case there may be other types of corruption (not that I'm advocating for more corruption!) 😛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next one will be CORRUPTED_DOOH 😎

yeah I can change it

@NejcZdovc
Adds broken seed overlay
1517df6 
Resolves brave#13424

Auditors:

Test Plan:
bsclifton
bsclifton approved these changes Mar 22, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (and works) great! 😄 👍

@NejcZdovc NejcZdovc merged commit 8bc5146 into brave:master Mar 22, 2018
NejcZdovc added a commit that referenced this pull request Mar 22, 2018
@NejcZdovc
Merge pull request #13551 from NejcZdovc/feature/#13424-seed
0672041 
Adds broken seed overlay
NejcZdovc added a commit that referenced this pull request Mar 22, 2018
@NejcZdovc
Merge pull request #13551 from NejcZdovc/feature/#13424-seed
f97d526 
Adds broken seed overlay
@NejcZdovc
Copy link
Contributor Author

master 8bc5146
0.23 0672041
0.22 f97d526

@mrose17 mrose17 mentioned this pull request Mar 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@mrose17 mrose17 mrose17 left review comments

@jonathansampson jonathansampson Awaiting requested review from jonathansampson

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging this pull request may close these issues.

When detecting a corrupted seed
4 participants
@NejcZdovc @codecov-io @mrose17 @bsclifton