Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update to Muon 5.0.6 (which has tab discarding fixes!) #13282

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Update to Muon 5.0.6 (which has tab discarding fixes!) #13282

merged 1 commit into from
Feb 23, 2018

Conversation

bsclifton
Copy link
Member

Fixes #12429

Auditors: @bridiver, @petemill

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

See #12429

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.21.x (Beta Channel) milestone Feb 23, 2018
@bsclifton bsclifton self-assigned this Feb 23, 2018
@bsclifton
Copy link
Member Author

The required follow up (after this) for tab discarding would be #13120

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #13282 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13282      +/-   ##
==========================================
- Coverage   56.09%   56.06%   -0.04%     
==========================================
  Files         282      282              
  Lines       28061    28061              
  Branches     4608     4608              
==========================================
- Hits        15741    15732       -9     
- Misses      12320    12329       +9
Flag Coverage Δ
#unittest 56.06% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 27.65% <0%> (-0.3%) ⬇️

@bsclifton bsclifton merged commit 437b8a0 into brave:master Feb 23, 2018
@bsclifton bsclifton deleted the update-muon-5.0.6 branch February 23, 2018 17:39
bsclifton added a commit that referenced this pull request Feb 23, 2018
Update to Muon 5.0.6 (which has tab discarding fixes!)
bsclifton added a commit that referenced this pull request Feb 23, 2018
Update to Muon 5.0.6 (which has tab discarding fixes!)
@bsclifton
Copy link
Member Author

master 437b8a0
0.22.x 67e511d
0.21.x f30cd05

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants