-
Notifications
You must be signed in to change notification settings - Fork 971
Add geth + Ethereum Wallet integration into Brave #13177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13177 +/- ##
==========================================
- Coverage 56.18% 55.96% -0.23%
==========================================
Files 279 281 +2
Lines 27873 27835 -38
Branches 4560 4566 +6
==========================================
- Hits 15660 15577 -83
- Misses 12213 12258 +45
|
let batAddress = null | ||
const indexUrl = `${window.location.origin}/index.html` | ||
|
||
ipc.send('get-popup-bat-balance') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have a good way to do state updates in extensions with redux so an ipc message is ok, but for sending messages to the browser process we should be using actions which do work in extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem is sending the message back to the popup window, which is a browserAction popup and not in the redux appState. is there a way to get the correct webcontents in reducers using event.sender.getId()
if the sender isn't a redux tab?
closing in favor of the updated branch #14734 |
Steps:
about:preferences#extensions
Video demo: https://youtu.be/gIS2RVq_5R4
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests