This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
New debug menu option - 'Allow Manual Tab Discarding': creates 'Discard' tab context menu command #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
force-pushed
the
feature/manual-tab-discard
branch
from
eebe586
to
2c44eff
Compare
Codecov Report
@@ Coverage Diff @@
## master #13118 +/- ##
==========================================
- Coverage 56.36% 56.3% -0.06%
==========================================
Files 278 278
Lines 27550 27588 +38
Branches 4491 4496 +5
==========================================
+ Hits 15528 15533 +5
- Misses 12022 12055 +33
|
bsclifton
reviewed
Feb 13, 2018
| @@ -20,7 +20,7 @@ const settings = require('../../js/constants/settings') | |||
|
|
|||
| // State | |||
| const {getByTabId} = require('../common/state/tabState') | |||
| const tabState = require('../../app/common/state/tabState') | |||
| const tabState = require('../common/state/tabState') | |||
There was a problem hiding this comment.
weird; the path before was invalid, right? did references before to tabState work (before this PR)?
There was a problem hiding this comment.
it was not invalid, we just went one more step up and then back into the app folder
There was a problem hiding this comment.
where now we just go one folder up and then into common
There was a problem hiding this comment.
ah- I totally see it now 😄 Was up past bedtime and didn't catch that LOL
There was a problem hiding this comment.
yep, just some tiny clean up whilst there
petemill
changed the title
…scard' tab context menu command
bsclifton
force-pushed
the
feature/manual-tab-discard
branch
from
2c44eff
to
104c09a
Compare
bsclifton
added a commit
that referenced
this pull request
Feb 13, 2018
New debug menu option - 'Allow Manual Tab Discarding': creates 'Discard' tab context menu command
bsclifton
added a commit
that referenced
this pull request
Feb 13, 2018
New debug menu option - 'Allow Manual Tab Discarding': creates 'Discard' tab context menu command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Note: that you will not be able to switch to the tab due to #10673 which this debug menu option is designed to help fix!
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests