Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Temporarily disable autodiscardable tabs #12917

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 30, 2018

Fix #12916

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • [ x Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.20.x (Beta Channel) milestone Jan 30, 2018
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver
Copy link
Collaborator

cc @petemill

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to reduce the impact of the issue for now

@bbondy bbondy merged commit d00d99c into master Jan 30, 2018
bbondy added a commit that referenced this pull request Jan 30, 2018
Temporarily disable autodiscardable tabs
bbondy added a commit that referenced this pull request Jan 30, 2018
Temporarily disable autodiscardable tabs
@bbondy
Copy link
Member Author

bbondy commented Jan 30, 2018

master: d00d99c
0.21.x: 6bd26ca
0.20.x: fe4cee7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants