Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes empty elements on CoinMarketCap #12756

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Removes empty elements on CoinMarketCap #12756

merged 1 commit into from
Jan 21, 2018

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Jan 20, 2018

Fixes #12755

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Navigate to CoinMarketCap
  2. Confirm that empty elements in header and footer are collapsed/removed

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

@bbondy
Copy link
Member

bbondy commented Jan 20, 2018

@bsclifton would you be able to land this with 0.20.x?

@bsclifton
Copy link
Member

@bbondy sure thing 😄 👍

@bsclifton bsclifton added this to the 0.20.x (Beta Channel) milestone Jan 21, 2018
@bsclifton bsclifton merged commit a3b96a2 into master Jan 21, 2018
@bsclifton bsclifton deleted the issue-12755 branch January 21, 2018 04:31
bsclifton added a commit that referenced this pull request Jan 21, 2018
Removes empty elements on CoinMarketCap
bsclifton added a commit that referenced this pull request Jan 21, 2018
Removes empty elements on CoinMarketCap
@bsclifton
Copy link
Member

master a3b96a2
0.21.x c68b3e7
0.20.x cc73feb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants