Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

chrome.contextMenus.remove && chrome.contextMenus.update #12659

Closed
wants to merge 4 commits into from
Closed

chrome.contextMenus.remove && chrome.contextMenus.update #12659

wants to merge 4 commits into from

Conversation

dividinglimits
Copy link

@dividinglimits dividinglimits commented Jan 15, 2018

supports: #8789 and #8332
updates: #8331

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
    Already exists
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
    Not necessary
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@dividinglimits dividinglimits changed the title [WIP] chrome.contextMenus.remove [WIP] chrome.contextMenus.remove && chrome.contextMenus.update Jan 15, 2018
@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #12659 into master will decrease coverage by 0.29%.
The diff coverage is 12.57%.

@@            Coverage Diff            @@
##           master   #12659     +/-   ##
=========================================
- Coverage   56.24%   55.94%   -0.3%     
=========================================
  Files         278      278             
  Lines       27115    27255    +140     
  Branches     4392     4414     +22     
=========================================
- Hits        15250    15248      -2     
- Misses      11865    12007    +142
Flag Coverage Δ
#unittest 55.94% <12.57%> (-0.3%) ⬇️
Impacted Files Coverage Δ
app/common/constants/extensionConstants.js 100% <ø> (ø) ⬆️
js/stores/appStore.js 16.11% <0%> (-0.1%) ⬇️
app/common/actions/extensionActions.js 24.13% <0%> (-3.87%) ⬇️
app/common/state/extensionState.js 35.23% <13.12%> (-25.7%) ⬇️
app/common/state/aboutNewTabState.js 94.87% <0%> (-5.13%) ⬇️
js/about/newtab.js 40.95% <0%> (-2.06%) ⬇️
app/common/state/pinnedSitesState.js 77.98% <0%> (-1.07%) ⬇️
app/browser/api/topSites.js 94.28% <0%> (-0.26%) ⬇️
app/sessionStore.js 88.79% <0%> (+0.04%) ⬆️
... and 2 more

Copy link
Contributor

@kevinlawler kevinlawler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice-looking changeset
I don't see any obvious red flags, but I am not an expert on the tab state, so can't comment on the soundness of the logic

@bsclifton bsclifton changed the title [WIP] chrome.contextMenus.remove && chrome.contextMenus.update chrome.contextMenus.remove && chrome.contextMenus.update Aug 9, 2018
@bsclifton
Copy link
Member

@jonathansampson did you want to give this a review? I know it's a bit old, but we could still merge this patch

@bsclifton bsclifton removed this from the Completed work milestone Sep 8, 2018
@bsclifton bsclifton added the stale label Sep 8, 2018
@bsclifton bsclifton closed this Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants