Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide windows until they are either rendered or a timeout expires #11764

Merged
merged 2 commits into from
Nov 22, 2017

Commits on Nov 22, 2017

  1. Hide windows until they are either rendered or a timeout expires.

    Separates parsing of APP_NEW_WINDOW action properties, and window creation / visibility logic.
    Moves window creation logic to windows API.
    Creates tests for existing APP_NEW_WINDOW action handler logic in windowsReducer
    Creates tests for new windows.createWindow logic
    Fixes test for downloadsReducer with not restoring a stub required by windowsReducer test
    
    Fix #8128
    petemill committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    8cf0919 View commit details
    Browse the repository at this point in the history
  2. Updated unit tests for argument parsing for window creation; fixed bu…

    …g w/ height
    
    Auditors: @petemill
    
    Test Plan: `npm run unittest -- --grep="APP_NEW_WINDOW"`
    bsclifton authored and petemill committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    ca54c13 View commit details
    Browse the repository at this point in the history