Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't allow controlling frame index from window renderer #11002

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 18, 2017

This mainly just reacts to index changes whenever they happen instead of controlling the window renderer index from tab moves.

It also simplifies the code a bit in terms of internal index which is the same as index on the window renderer.

Fix #10961

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 18, 2017
@bbondy bbondy self-assigned this Sep 18, 2017
@bbondy bbondy requested a review from bridiver September 18, 2017 18:17
Tab move no longer allows controlling of the frame index

Fix #10961
@bbondy bbondy merged commit 5d38cc1 into 0.19.x Sep 18, 2017
@bsclifton bsclifton deleted the 10961 branch September 18, 2017 20:04
@bbondy
Copy link
Member Author

bbondy commented Sep 18, 2017

0.19.x: 5f76327

0.20.x: 49426f2

master: 49426f2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants