Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

backward compatible for user-data-dir overrides #10959

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 14, 2017

required by brave/electron-squirrel-startup#3

Auditors: @bsclifton, @bbondy

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 30a47a6 into master Sep 15, 2017
@bsclifton bsclifton deleted the squirrel-check branch September 15, 2017 18:43
bsclifton added a commit that referenced this pull request Sep 15, 2017
backward compatible for user-data-dir overrides
bsclifton added a commit that referenced this pull request Sep 15, 2017
backward compatible for user-data-dir overrides
bsclifton added a commit that referenced this pull request Sep 15, 2017
backward compatible for user-data-dir overrides
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants