Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update ISSUE_TEMPLATE.md #10920

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Update ISSUE_TEMPLATE.md #10920

merged 2 commits into from
Sep 19, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 13, 2017

  • Add comment blocks
  • Replace list items with headers

Closes #10907
Based on mochajs/mocha#2869

Auditors:

Test Plan:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

- Add comments block
- Replace list items with headers

Closes #10907
Based on mochajs/mocha#2869

Auditors:

Test Plan:
@luixxiul luixxiul self-assigned this Sep 13, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 13, 2017

- Platform (Win7, 8, 10? macOS? Linux distro?):
For more, check out our community site: https://community.brave.com/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to add a link to our discord channel, which on the second thought seemed too much. If it isn't, I'll add that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the first line about visiting wiki makes sense at top. I would have it like this

Have you searched for similar issues? There is a lot of feedback and bug reports that we have received and closed as duplicate.  
Please search for existing issue via GitHub search or using a search engines. 

Please check our community site: https://communit.brave.com and also have a look at our Wiki: https://github.com/brave/browser-laptop/wiki/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the first line about visiting wiki makes sense at top.

I'd agree. I'll edit this comment block.

Before submitting this issue, please visit our wiki for common ones: https://github.com/brave/browser-laptop/wiki
By using search engines along with GitHub search function, you would be able to find duplicates more efficiently.

For more, check out our community site: https://community.brave.com/
Copy link
Contributor Author

@luixxiul luixxiul Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Discord community chat is available too. Join us for live discussions: https://discordapp.com/invite/k57tYrS

@luixxiul luixxiul added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 13, 2017
@bbondy bbondy merged commit 22c3129 into brave:master Sep 19, 2017
@bbondy
Copy link
Member

bbondy commented Sep 19, 2017

I think we'll want to tweak it, but I'm ok with this as the new starting point so merging.

@luixxiul luixxiul deleted the update-issue-template branch September 19, 2017 01:34
@luixxiul luixxiul removed the request for review from kjozwiak September 25, 2017 04:38
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@luixxiul luixxiul removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants