You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bbondy I have only one use case that I don't know how to handle it. Let's say that you visit a site and then you bookmark this site. After that you clear history and because we don't know that that history site is also bookmarked we delete it from the suggestion list. What I could do is to check for every single history site if it's bookmarked or not, but this could be quite a perf hit. Same goes if you delete a bookmark and you have history entry for that bookmark. I would need to check here as well if bookmark is inside history list. wdyt?
I think you could add something in the remove to check the item to see if it has some attribute or not, like bookmarked? Or some special tag on the item.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #9736
Auditors:
Test Plan:
Reviewer Checklist:
Tests