Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide enpass & metamask #10246

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Hide enpass & metamask #10246

merged 1 commit into from
Aug 3, 2017

Conversation

bsclifton
Copy link
Member

Fixes #10232

Auditors: @cezaraugusto

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  1. Visit Preferences > Extensions and verify both extensions are not shown
  2. Visit Preferences > Security and verify enpass is not shown

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #10232

Auditors: @cezaraugusto

Test Plan:
1. Visit Preferences > Extensions and verify both extensions are not shown
2. Visit Preferences > Security and verify enpass is not shown
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Aug 2, 2017
@bsclifton bsclifton self-assigned this Aug 2, 2017
@bsclifton bsclifton requested a review from cezaraugusto August 2, 2017 07:04
@codecov-io
Copy link

codecov-io commented Aug 2, 2017

Codecov Report

Merging #10246 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10246      +/-   ##
==========================================
- Coverage   52.95%   52.93%   -0.02%     
==========================================
  Files         228      228              
  Lines       20308    20308              
  Branches     3254     3254              
==========================================
- Hits        10754    10750       -4     
- Misses       9554     9558       +4
Flag Coverage Δ
#unittest 52.93% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
app/renderer/lib/extensionsUtil.js 58.88% <ø> (-1.56%) ⬇️
js/about/preferences.js 42.79% <ø> (+0.11%) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit f4e58cd into brave:master Aug 3, 2017
cezaraugusto added a commit that referenced this pull request Aug 3, 2017
cezaraugusto added a commit that referenced this pull request Aug 3, 2017
@andrewalker
Copy link
Contributor

May I ask why it was hidden again? I went to all the relevant issues and pull requests (#9546, #7778, #10232) which just link to each other and don't explain anything. Is there a public place where these issues are discussed?

@luixxiul
Copy link
Contributor

luixxiul commented Aug 3, 2017

Please see #10232 (comment), thanks.

@bsclifton bsclifton deleted the hide-metamask-enpass branch August 3, 2017 23:23
@bsclifton bsclifton restored the hide-metamask-enpass branch August 3, 2017 23:23
@bsclifton bsclifton deleted the hide-metamask-enpass branch August 3, 2017 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants