Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove webSecurity:false in webPreferences #10242

Merged
merged 1 commit into from
Sep 13, 2017
Merged

remove webSecurity:false in webPreferences #10242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/browser/reducers/windowsReducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,9 @@ function windowDefaults (state) {
minModalWidth: 100,
windowOffset: 20,
webPreferences: {
// XXX: Do not edit without security review
sharedWorker: true,
nodeIntegration: false,
partition: 'default',
webSecurity: false,
allowFileAccessFromFileUrls: true,
allowUniversalAccessFromFileUrls: true
partition: 'default'
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/browser/share.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const {shell} = require('electron')
const tabs = require('./tabs')

const templateUrls = {
email: 'mailto:?subject={title}&body={url}',
email: 'mailto:?subject={title}&body={url}', // Do not edit without security review
facebook: 'https://www.facebook.com/sharer.php?u={url}',
pinterest: 'https://pinterest.com/pin/create/bookmarklet/?url={url}&description={title}',
twitter: 'https://twitter.com/intent/tweet?url={url}&text={title}&hashtags=brave',
Expand Down