-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comment here #9437 (comment). I think it would be better to override browserActions
with new tabAction
data then other way around. This way if browserActions
and tabAction
have the same value we would use tabAction
's value.
Codecov Report
@@ Coverage Diff @@
## master #10197 +/- ##
==========================================
+ Coverage 52.78% 52.79% +<.01%
==========================================
Files 227 227
Lines 20217 20214 -3
Branches 3236 3236
==========================================
Hits 10672 10672
+ Misses 9545 9542 -3
|
7d898bd
to
b93b088
Compare
I just tried it again and this fix fixes icon problem, but if you click on an icon nothing happens. But if you click on an icon when you are on new tab, popup is shown. |
@NejcZdovc This PR is meant only to resolve the missing icon issue. I'm going to look into the reason behind unresponsive icons next. Also testing the latest version of bitwarden in the process; attempting to take out as many birds with as few stones as possible :) |
@NejcZdovc looks like you missed 0.20.x when cherry-picking into branches. I went ahead and made sure it's included in there: e4e0cf6 |
BTW- awesome job knocking this out, @jonathansampson 😄 |
@bsclifton you are right, I forgot that we are already on 0.21 😄 thank you |
Submitter Checklist:
git rebase -i
to squash commits (if needed).Fixes #9437
Test Plan:
Ensure that bitwarden browserAction icon is visible.
Reviewer Checklist:
Tests