Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove spellchecker packaging #10068

Merged
merged 1 commit into from
Jul 23, 2017
Merged

Remove spellchecker packaging #10068

merged 1 commit into from
Jul 23, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jul 19, 2017 •
edited by bsclifton
Loading

fixes #10060

Auditors: @bsclifton

Test Plan:
Run CHANNEL=dev npm run build-package

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@darkdh
Remove spellchecker packaging
e5c6622 
fixes #10060

Auditors: @bsclifton

Test Plan:
Run `CHANNEL=dev npm run build-package`
@darkdh darkdh self-assigned this Jul 19, 2017
@darkdh darkdh requested a review from bsclifton July 19, 2017 21:25
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Jul 19, 2017
bsclifton
bsclifton approved these changes Jul 23, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 ++

@bsclifton bsclifton merged commit 26d47fe into master Jul 23, 2017
@bsclifton bsclifton deleted the 10060 branch July 23, 2017 06:26
bsclifton added a commit that referenced this pull request Jul 23, 2017
@bsclifton
Merge pull request #10068 from brave/10060
ef77be0 
Remove spellchecker packaging
@bsclifton bsclifton modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 23, 2017
bsclifton added a commit that referenced this pull request Jul 23, 2017
@bsclifton
Merge pull request #10068 from brave/10060
8d89b53 
Remove spellchecker packaging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@darkdh darkdh

Labels
dev-setup QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging this pull request may close these issues.

Error while build-package
2 participants
@darkdh @bsclifton