Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in Navigator #9751

Closed
NejcZdovc opened this issue Jun 28, 2017 · 0 comments
Closed

Only primitives in Navigator #9751

NejcZdovc opened this issue Jun 28, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 28, 2017 •
edited by luixxiul
Loading

Test plan

#9752 (comment)

Describe the issue you encountered:
Convert extensionBrowserActions into List of strings instead of Object of strings. This way check will work.
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
Refactors Navigator into primitives only
d7e803e 
Resolves brave#9751

Auditors: @bsclifton @bridiver

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 28, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc added the perf label Jun 28, 2017
NejcZdovc added a commit that referenced this issue Jun 29, 2017
@NejcZdovc
Merge pull request #9752 from NejcZdovc/refactor/#9751-navigator
a93609f 
Refactors Navigator into primitives only
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags