Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Context menu not working for tabs toolbar #9524

Closed
NejcZdovc opened this issue Jun 16, 2017 · 3 comments
Closed

Context menu not working for tabs toolbar #9524

NejcZdovc opened this issue Jun 16, 2017 · 3 comments
Assignees
@NejcZdovc
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.17.13 (Release ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 16, 2017 •
edited by luixxiul
Loading

Test plan

#9525 (comment)

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Context menu not working for tabs toolbar

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    1007e8c

  • Steps to reproduce:

    1. Right click on tabs toolbar (on empty space)

  • Actual result:
    You get an error

  • Expected result:
    Context menu opens

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@NejcZdovc NejcZdovc added this to the 0.17.x (Beta Channel) milestone Jun 16, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 16, 2017
@NejcZdovc
Fixes context menu not working on tabsbar
cdaad86 
Resolves brave#9524

Auditors: @bsclifton

Test Plan:
- right click on tabs toolbar (on empty space)
- context menu should open
@NejcZdovc NejcZdovc mentioned this issue Jun 16, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc added regression and removed bug labels Jun 16, 2017
@bsclifton
Copy link
Member

We may want to close this in favor of #8303

@NejcZdovc
Copy link
Contributor Author

This are not the same, so we can't close this one. Comment left here #9525 (comment)

bsclifton added a commit that referenced this issue Jun 19, 2017
@bsclifton
Merge pull request #9525 from NejcZdovc/hotfix/#9524-tabsbar
fab48e2 
Fixes context menu not working on tabsbar
bsclifton added a commit that referenced this issue Jun 19, 2017
@bsclifton
Merge pull request #9525 from NejcZdovc/hotfix/#9524-tabsbar
5e9b60c 
Fixes context menu not working on tabsbar
bsclifton added a commit that referenced this issue Jun 19, 2017
@bsclifton
Merge pull request #9525 from NejcZdovc/hotfix/#9524-tabsbar
92cc6fd 
Fixes context menu not working on tabsbar
This was referenced Jun 19, 2017
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Works fine but need confirmation for #9525 (comment) if that the expected behavoir

@Jacalz Jacalz mentioned this issue Jun 21, 2017
Closed
94 tasks
@alexwykoff alexwykoff mentioned this issue Jun 22, 2017
Closed
@LaurenWags LaurenWags mentioned this issue Jun 23, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

No branches or pull requests
6 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags