Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

clicking menu bar items in 0.16.x and 0.17.1 does nothing #9470

Closed
dillbyrne opened this issue Jun 14, 2017 · 12 comments · Fixed by brave/muon#220
Closed

clicking menu bar items in 0.16.x and 0.17.1 does nothing #9470

dillbyrne opened this issue Jun 14, 2017 · 12 comments · Fixed by brave/muon#220
Assignees
@bsclifton
Labels
bug OS/unix-like/linux QA/test-plan-specified release-notes/include
Milestone
0.16.13

Comments

@dillbyrne
Copy link

dillbyrne commented Jun 14, 2017 •
edited by luixxiul
Loading

Test plan

  1. Start browser
  2. click on a menu item or show the menu and click on a menu item

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Clicking on menu items does nothing.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    kde 4.14.2 on debian 8 x64

  • Brave Version (revision SHA):

    Name Version
    Brave 0.16.9
    rev fba98fc
    Muon 4.0.2
    libchromiumcontent 59.0.3071.86
    V8 5.9.211.31
    Node.js 7.9.0
    Update Channel dev
    os.platform linux
    os.release 4.9.0-0.bpo.1-amd64
    os.arch x64

  • Steps to reproduce:

    1. Start browser
    2. click on a menu item or show the menu and click on a menu item

  • Actual result:
    Nothing happens

  • Expected result:
    The menu item should show the relevant drop down menu.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes. I tried several versions of the browser each time deleting ~/.config/brave .

    It was present in 0.16.x and in 0.17.1 releases that I tested.
    However the menu works as expected in the following release.

    Name Version
    Brave 0.15.314
    libchromiumcontent 58.0.3029.110
    Muon 3.0.202
    Node.js 7.9.0
    os.arch x64
    os.platform linux
    os.release 4.9.0-0.bpo.1-amd64
    rev 75ffa36
    Update Channel dev
    V8 5.8.283.38

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes in my case

  • Any related issues:
    Hide the menu bar by default stopped working #5086 may be related as I am also experiencing that with the current version on kde4 in debian 8

  • Additional Information
    I do not have any global menu kde widgets in use.
    I have tested it with both the oxygen and qtcurve widget styles to be sure and it made no difference. It appears the regression may have been introduced in the 0.16.x releases.
@luixxiul
Copy link
Contributor

I confirmed the issue on Debian (MATE).

@luixxiul luixxiul added this to the 0.17.x (Beta Channel) milestone Jun 15, 2017
@bsclifton bsclifton self-assigned this Jun 15, 2017
@bsclifton
Copy link
Member

Related to brave/muon#161 and Chromium 59 update... Looking into this

@oddballhero
Copy link

Confirmed this issue on Debian Mate and Fluxbox (multiple different machines).

@eljuno
Copy link
Contributor

eljuno commented Jun 16, 2017

+4 from community

@bsclifton
Copy link
Member

bsclifton commented Jun 17, 2017 •
edited
Loading

Release() is being called on the MenuRunner object (which causes the menu to close immediately)

It looks like we'll need to capture an instance of the MenuDelegate in the Muon code (which is what triggers the MenuRunner so that it doesn't call destructor when it goes out of scope

bsclifton added a commit to brave/muon that referenced this issue Jun 17, 2017
@bsclifton
Keep reference to MenuDelegate as a member (so it won't go out of sco…
dda76e1 
…pe and auto-close/destroy).

Fixes brave/browser-laptop#9470

Auditor: @darkdh
bsclifton added a commit to brave/muon that referenced this issue Jun 17, 2017
@bsclifton
Keep reference to MenuDelegate as a member (so it won't go out of sco…
5173838 
…pe and auto-close/destroy).

Fixes brave/browser-laptop#9470

Auditor: @darkdh
@bsclifton bsclifton mentioned this issue Jun 17, 2017
Merged
bridiver pushed a commit to brave/muon that referenced this issue Jun 17, 2017
@bsclifton @bridiver
Keep reference to MenuDelegate as a member (so it won't go out of sco…
fdf9f8e 
…pe and auto-close/destroy).

Fixes brave/browser-laptop#9470

Auditor: @darkdh
bridiver pushed a commit to brave/muon that referenced this issue Jun 17, 2017
@bsclifton @bridiver
Keep reference to MenuDelegate as a member (so it won't go out of sco…
59d91fd 
…pe and auto-close/destroy).

Fixes brave/browser-laptop#9470

Auditor: @darkdh
@luixxiul luixxiul mentioned this issue Jun 19, 2017
Closed
This was referenced Jun 19, 2017
Closed
Closed
@bsclifton
Copy link
Member

Heads up folks! The fix for this issue has been pushed. Please use your package manager of choice to update to the latest release, which should be 0.16.11 😄 👍

Please let me know if you are having trouble updating

bridiver pushed a commit to brave/muon that referenced this issue Jun 20, 2017
@bsclifton @bridiver
Keep reference to MenuDelegate as a member (so it won't go out of sco…
f814c29 
…pe and auto-close/destroy).

Fixes brave/browser-laptop#9470

Auditor: @darkdh
@oddballhero
Copy link

oddballhero commented Jun 20, 2017 •
edited
Loading

Works in Debian Fluxbox, does not work with Debian Mate, at least for me.
Edit:
This was after updating to Brave 0.16.12.
Edit:
Debian Fluxbox was at 0.16.11, updated it to 0.16.12 and menu bar not working again.

@oddballhero oddballhero mentioned this issue Jun 20, 2017
Closed
@cndouglas
Copy link

Users are still having issues. Tracking in #9606.

@luixxiul
Copy link
Contributor

updated it to 0.16.12 and menu bar not working again

Confirmed on Debian on Gnome

with 0.16.12, 72624a2

@luixxiul
Copy link
Contributor

Fixed on 0.17.4 :-)

@luixxiul luixxiul added this to the 0.16.x menu hotfix milestone Jun 21, 2017
@luixxiul luixxiul removed this from the 0.17.x (Beta Channel) milestone Jun 21, 2017
@dillbyrne
Copy link
Author

Fixed on Debian 8 KDE with 0.17.4. 👍

@oddballhero
Copy link

Works in Debian Stable Fluxbox and Debian Stable Mate with Brave 0.16.13 without different issue seen in 0.16.11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug OS/unix-like/linux QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.16.13
Development

Successfully merging a pull request may close this issue.

Fix broken menus on Linux / Gnome (introduced w/ C59) brave/muon
6 participants
@dillbyrne @luixxiul @bsclifton @cndouglas @eljuno @oddballhero