Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Redux component - Tab page #9339

Closed
NejcZdovc opened this issue Jun 8, 2017 · 0 comments · Fixed by #9414
Closed

Redux component - Tab page #9339

NejcZdovc opened this issue Jun 8, 2017 · 0 comments · Fixed by #9414

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 8, 2017

Test plan

See #9414 (comment)

Original issue description

Describe the issue you encountered:
Convert TabPage and TabPages into redux component.

@NejcZdovc NejcZdovc added this to the 0.18.x milestone Jun 8, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 8, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Nightly Channel), 0.18.x (Developer Channel) Jun 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
Resolves brave#9339

Auditors: @bsclifton @bridiver

Test Plan:
- try to open enaugh tabs to trigger tab page (default is 20)
- see if audio indicator is displayed if you have video playing in tab page
- check if you can close tab page
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
Resolves brave#9339

Auditors: @bsclifton @bridiver

Test Plan:
- try to open enaugh tabs to trigger tab page (default is 20)
- see if audio indicator is displayed if you have video playing in tab page
- check if you can close tab page
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
Resolves brave#9339

Auditors: @bsclifton @bridiver

Test Plan:
- try to open enaugh tabs to trigger tab page (default is 20)
- see if audio indicator is displayed if you have video playing in tab page
- check if you can close tab page
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 14, 2017
Resolves brave#9339

Auditors: @bsclifton @bridiver

Test Plan:
- try to open enaugh tabs to trigger tab page (default is 20)
- see if audio indicator is displayed if you have video playing in tab page
- check if you can close tab page
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.