Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Every URL navigation takes 1000+ ms in updateSiteFavicon (With 10K bookmarks) #9276

Closed
ayumi opened this issue Jun 5, 2017 · 0 comments
Closed

Comments

@ayumi
Copy link
Contributor

ayumi commented Jun 5, 2017

Test plan

#9279 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Navigating to URLs and clicking links is very slow with 10K bookmarks.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    e14a9db

  • Steps to reproduce:

    1. Instrument siteUtil.updateSiteFavicon() to measure its runtime.
    2. Load 10K bookmarks.
    3. Go to https://github.com/brave/browser-laptop and see how long updateSiteFavicon takes.
    4. Click the H1 link "browser-laptop" to navigate to the same page and see how long updateSiteFavicon takes.
  • Actual result:
    First navigation takes 1000 ms.
    Clicking the link to itself takes 1000 * 2 ms.

  • Expected result:
    < 100 ms

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes; with 10K bookmarks

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Refreshing / navigating away from large pages is very slow #7162

@ayumi ayumi changed the title Every URL navigation takes 1000+ ms in updateSiteFavicon (with 10K bookmarks) Every URL navigation takes 1000+ ms in updateSiteFavicon (With 10K bookmarks) Jun 5, 2017
@ayumi ayumi added the perf label Jun 5, 2017
@ayumi ayumi self-assigned this Jun 6, 2017
ayumi added a commit that referenced this issue Jun 6, 2017
Fix #9276

Auditors: @bsclifton @bbondy

Test Plan:
1. Enable bookmarks bar favicons via Preferences > General > "Bookmarks Bar" => "Text and Favicons".
2. Create a bookmark folder.
3. Navigate to https://archive.org
4. Bookmark page.
5. Navigate to https://wikipedia.org
6. Bookmark page into the folder.
7. Examine bookmarks toolbar; there should be favicons for archive and wikipedia.
8. Open the Bookmarks Manager and confirm there are favicons.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.