Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

View log shows console errors when checking for update #9122

Closed
srirambv opened this issue May 29, 2017 · 5 comments
Closed

View log shows console errors when checking for update #9122

srirambv opened this issue May 29, 2017 · 5 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    View log shows console errors when checking for update

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.16.0
    rev be76cd3
    Muon 3.2.101

  • Steps to reproduce:

    1. Set brave to an older version in system variables
    2. Launch browser and click on check for update
    3. Open browser console and click on view log button, shows console error, doesn't open the log file
  • Actual result:
    View log shows console errors when checking for update

  • Expected result:
    Should open the log file

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    viewlog

  • Any related issues:
    cc: @bbondy

@bbondy
Copy link
Member

bbondy commented May 29, 2017

This one has been there for a long time, since we removed node from renderers. I agree we should fix now though.

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 7, 2017

Still an issue on Windows. Reopening the issue
1

@srirambv srirambv reopened this Jun 7, 2017
@alexwykoff
Copy link
Contributor

confirmed not working on os x as well

@bsclifton bsclifton modified the milestones: 0.17.x (Frozen, only critical adds from here), 0.16.x (Frozen, only critical adds from here) Jun 7, 2017
@bbondy bbondy modified the milestones: 0.16.x (Frozen, only critical adds from here), 0.17.x (Frozen, only critical adds from here) Jun 7, 2017
@bbondy
Copy link
Member

bbondy commented Jun 7, 2017

re-added to milestone 0.16.x, looks like it just doesn't exist on that branch when it should have at merge time.

bbondy added a commit that referenced this issue Jun 7, 2017
@bbondy
Copy link
Member

bbondy commented Jun 7, 2017

cherry-picked it into 0.16.x now, it'll be in rc2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.